linux-kernel - Re: [PATCH v2 1/4] perf-events: Add support for supplementary event registers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTimBgKukb+aWP7supmTkF0RbTjmj-E49RtCnjUt7@mail.gmail.com>
Date:	Wed, 2 Mar 2011 13:07:42 +0100
From:	Stephane Eranian <eranian@...gle.com>
To:	Peter Zijlstra <a.p.zijlstra@...llo.nl>
Cc:	Lin Ming <ming.m.lin@...el.com>, Ingo Molnar <mingo@...e.hu>,
	Andi Kleen <andi@...stfloor.org>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 1/4] perf-events: Add support for supplementary event registers

On Wed, Mar 2, 2011 at 11:34 AM, Peter Zijlstra <a.p.zijlstra@...llo.nl> wrote:
> On Wed, 2011-03-02 at 08:48 +0100, Stephane Eranian wrote:
>> >> >        __u32                   bp_type;
>> >> > -       __u64                   bp_addr;
>> >> > -       __u64                   bp_len;
>> >> > +       union {
>> >> > +               __u64           bp_addr;
>> >> > +               __u64           config1; /* extension of config0 */
>> >> > +       };
>> >> > +       union {
>> >> > +               __u64           bp_len;
>> >> > +               __u64           config2; /* extension of config1 */
>> >> > +       };
>> >> >  };
>> >> >
>> >> I don't see where those config0 or config1 are coming from.
>> >
>> > config0 means perf_event_attr::config.
>> >
>> yes.
>>
>> > Peter suggested to extend the attr config space.
>> > http://marc.info/?l=linux-kernel&m=129838808907525&w=2
>> >
>> Ok, I get it, it is cascading. that's fine.
>
> I initially put config and config0 in a union, but that made compilation
> fail and fixing that up vs the benefit of actually having a config0,
> which seemed near 0, led me to drop that part. Forgot to update the
> comment though ;-)
>
Ok, but that's not committed yet, isn't it?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/