linux-kernel - Re: [PATCH -tip 1/2 resend] x86, nmi: Define a name for NMI control port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110302193533.GY11359@redhat.com>
Date:	Wed, 2 Mar 2011 14:35:33 -0500
From:	Don Zickus <dzickus@...hat.com>
To:	Cyrill Gorcunov <gorcunov@...nvz.org>
Cc:	Ingo Molnar <mingo@...e.hu>, "Huang, Ying" <ying.huang@...el.com>,
	lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -tip 1/2 resend] x86, nmi: Define a name for NMI control
 port

On Wed, Mar 02, 2011 at 06:32:30PM +0300, Cyrill Gorcunov wrote:
> Also add a comment anout why we need in-out operations.
> 
> Signed-off-by: Cyrill Gorcunov <gorcunov@...nvz.org>
> ---
> 
> Ingo I hope this time I've resolved MUA space injection.
> 
>  arch/x86/include/asm/mach_traps.h |   18 +++++++++++++-----
>  1 file changed, 13 insertions(+), 5 deletions(-)
> 
> Index: linux-2.6.git/arch/x86/include/asm/mach_traps.h
> =====================================================================
> --- linux-2.6.git.orig/arch/x86/include/asm/mach_traps.h
> +++ linux-2.6.git/arch/x86/include/asm/mach_traps.h
> @@ -8,6 +8,7 @@
>  #include <asm/mc146818rtc.h>
> 
>  #define NMI_REASON_PORT		0x61
> +#define NMI_ENABLE_PORT		0x70 /* Real-Time Clock Address Register as well */
> 
>  #define NMI_REASON_SERR		0x80
>  #define NMI_REASON_IOCHK	0x40
> @@ -30,12 +31,19 @@ static inline void reassert_nmi(void)
>  		old_reg = current_lock_cmos_reg();
>  	else
>  		lock_cmos(0); /* register doesn't matter here */
> -	outb(0x8f, 0x70);
> -	inb(0x71);		/* dummy */

I was wondering if 0x71 should get a name change too.  Then again I can't
find the Intel doc that tells me what 0x70 is either (I remember seeing it
somewhere).

Cheers,
Don
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/