linux-kernel - Re: [PATCH v8 1/1] PRUSS UIO driver support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.1103022155030.2701@localhost6.localdomain6>
Date:	Wed, 2 Mar 2011 21:56:37 +0100 (CET)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Arnd Bergmann <arnd@...db.de>
cc:	"Hans J. Koch" <hjk@...sjkoch.de>,
	Pratheesh Gangadhar <pratheesh@...com>,
	linux-kernel@...r.kernel.org, gregkh@...e.de, sshtylyov@...sta.com,
	amit.chatterjee@...com,
	davinci-linux-open-source@...ux.davincidsp.com,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v8 1/1] PRUSS UIO driver support

On Wed, 2 Mar 2011, Arnd Bergmann wrote:

> On Wednesday 02 March 2011 21:09:56 Hans J. Koch wrote:
> > > +static struct uio_info *info;
> > > +static dma_addr_t sram_paddr, ddr_paddr;
> > > +static void *prussio_vaddr, *sram_vaddr, *ddr_vaddr;
> > 
> > So the correct thing would be
> > 
> > static void __iomem *prussio_vaddr;
> > static void *sram_vaddr, *ddr_vaddr;
> 
> I also commented that it should not be a global variable at
> all, but a dynamic data structure referenced from the device.
> 
> Not important, but Pratheesh said he'd change it. If it stays
> a global variable, I'd at least expect an explanation why
> the static variable is considered better in this case.

I did not pick at that, because there is no indicator that we'll see
more than one PRUSS unit per SoC in the forseeable future.

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/