linux-kernel - Re: [PATCH] procfs: fix /proc/<pid>/maps heap check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 3 Mar 2011 13:37:37 +0200 (EET)
From:	Aaro Koskinen <aaro.koskinen@...ia.com>
To:	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
cc:	Aaro Koskinen <aaro.koskinen@...ia.com>, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	stable@...nel.org
Subject: Re: [PATCH] procfs: fix /proc/<pid>/maps heap check

Hi,

On Thu, 3 Mar 2011, KOSAKI Motohiro wrote:
>> On Tue, 1 Mar 2011, Aaro Koskinen wrote:
>>> The current check looks wrong and prints "[heap]" only if the mapping
>>> matches exactly the heap. However, the heap may be merged with some
>>> other mappings, and there may be also be multiple mappings.
>>>
>>> Signed-off-by: Aaro Koskinen <aaro.koskinen@...ia.com>
>>> Cc: stable@...nel.org

[...]

> Your description said,
> 	the heap may be merged with some other mappings,
>                        ^^^^^^
> but your example is splitting case. not merge. In other words, your
> patch care splitting case but break merge case.
>
> Ok, we have no obvious correct behavior. This is debatable. So,
> Why do you think vma splitting case is important than merge?

Sorry, I was unclear.

The current behaviour is wrong for both merged and split cases, and I
think the patch fixes both.

And yes, the example program is for the split case. I'll see if I can
make a test program for the merged case...

A.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/