linux-kernel - Re: [perfmon2] [PATCH] Add libpfm4 support (v2).

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AANLkTimaULacASp7vtgo_RFexUyKH1ZEUVyNy-EXZ1hE@mail.gmail.com>
Date:	Wed, 2 Mar 2011 19:44:51 -0800
From:	Arun Sharma <arun@...rma-home.net>
To:	Lin Ming <minggr@...il.com>
Cc:	Arun Sharma <asharma@...com>, acme@...radead.org,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>, ming.m.lin@...el.com,
	Frederic Weisbecker <fweisbec@...il.com>,
	Mike Galbraith <efault@....de>,
	lkml <linux-kernel@...r.kernel.org>,
	Stephane Eranian <eranian@...gle.com>,
	Tom Zanussi <tzanussi@...il.com>,
	Paul Mackerras <paulus@...ba.org>, Ingo Molnar <mingo@...e.hu>,
	Thomas Gleixner <tglx@...utronix.de>,
	perfmon2-devel@...ts.sourceforge.net
Subject: Re: [perfmon2] [PATCH] Add libpfm4 support (v2).

On Wed, Mar 2, 2011 at 7:20 PM, Lin Ming <minggr@...il.com> wrote:
>> +#ifdef LIBPFM4
>> +       printf("\n");
>> +       pfm_for_all_pmus(i) {
>> +               int ret;
>> +               pfm_pmu_info_t pinfo;
>> +               int count;
>> +               int k;
>> +
>
> Need to initialize pinfo before passing it to pfm_get_pmu_info
> +               memset(&pinfo, 0, sizeof(pinfo));
>
>> +               ret = pfm_get_pmu_info(i, &pinfo);

You can get by using my next patch which initializes pinfo.size, but
zero'ing the entire structure is a better idea (needs to be done for
attr too). I'll get this into -v3.

 -Arun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/