| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Fri, 4 Mar 2011 15:38:37 +0300 From: Cyrill Gorcunov <gorcunov@...il.com> To: Ingo Molnar <mingo@...e.hu> Cc: David Rientjes <rientjes@...gle.com>, Yinghai Lu <yinghai@...nel.org>, Tejun Heo <tj@...nel.org>, Ingo Molnar <mingo@...hat.com>, "H. Peter Anvin" <hpa@...or.com>, tglx@...utronix.de, brgerst@...il.com, shaohui.zheng@...el.com, linux-kernel@...r.kernel.org Subject: Re: [patch] x86, mm: Clean up initmem_init On Fri, Mar 4, 2011 at 10:08 AM, Ingo Molnar <mingo@...e.hu> wrote: ... >> >> It's a matter of style and I think it's up to Ingo what he'd prefer to >> see. > > I think your variant is cleaner: hiding function call side-effects in conditionscan > be a fragile thing to do. We want constant expressions with no side-effects - so if > functions are called they should be constant functions as well. Well, we do it a lot with say strcmp and others so I would use rather semantic argument, but I agree that David's version is easier to read and mark same time that these functions are important steps in bootup procedure. So I'm sorry for proposing this change in first place. > > Code compactness isn't everything - if it was we'd be using C to the max to create > unreadable compound expressions all the time. > > Thanks, > > Ingo > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists