| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20110304132551.GA2407@infradead.org> Date: Fri, 4 Mar 2011 08:25:51 -0500 From: "hch@...radead.org" <hch@...radead.org> To: Jens Axboe <jaxboe@...ionio.com> Cc: Vivek Goyal <vgoyal@...hat.com>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "hch@...radead.org" <hch@...radead.org> Subject: Re: [PATCH 07/10] fs: make generic file read/write functions plug On Fri, Mar 04, 2011 at 02:22:21PM +0100, Jens Axboe wrote: > Good catch, we need to modify that logic. If the task is currently > plugged, it should not dispatch until blk_finish_plug() is called. > Essentially SYNC will not control dispatch. Will allow us to clean up > that logic, too. <broken-record-mode> Time to use the opportunity to sort out what the various bio/request flags mean. REQ_UNPLUG should simply go away with the explicit stack plugging. What's left for REQ_SYNC? It'll control if the request goes into the sync bucket and some cfq tweaks. We should clearly document what it does. REQ_META? Maybe we should finally agree what it does and decide if it should be used consistenly. Especially the priority over REQ_SYNC in cfq still looks somewhat odd, as does the totally inconsequent use. </broken-record-mode> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists