linux-kernel - Re: linux-next: Tree for February 21 (usb/serial)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1103040953380.1812-100000@iolanthe.rowland.org>
Date:	Fri, 4 Mar 2011 10:04:38 -0500 (EST)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Oliver Neukum <oliver@...kum.org>,
	Randy Dunlap <randy.dunlap@...cle.com>
cc:	lud <linux-usb@...r.kernel.org>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	<linux-next@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org>,
	"Rafael J. Wysocki" <rjw@...k.pl>
Subject: Re: linux-next: Tree for February 21 (usb/serial)

On Thu, 3 Mar 2011, Randy Dunlap wrote:

> On Mon, 21 Feb 2011 21:30:01 +0100 Rafael J. Wysocki wrote:
> 
> > On Monday, February 21, 2011, Randy Dunlap wrote:
> > > On Mon, 21 Feb 2011 18:21:34 +1100 Stephen Rothwell wrote:
> > > 
> > > > Hi all,
> > > > 
> > > > Changes since 20110218:
> > > 
> > > 
> > > When CONFIG_PM_RUNTIME is not enabled:
> > > 
> > > drivers/usb/serial/usb_wwan.c:702: error: 'struct dev_pm_info' has no member named 'usage_count'
> > 
> > This looks like a bug in the driver that shouldn't access this field directly.
> 
> 
> This build error is still with us in linux-next 2011.0303.

Since Oliver added this bug in commit
16871dcac74c63227aa92e0012f3004a648c2062 (usb_wwan: error case of
resume), he should be the person to fix it.  The logic there is not 
clear to me; I don't know how it ought to be changed.  Would replacing 
it with a call to usb_autopm_put_interface_no_suspend() be good enough?

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/