linux-kernel - [RFC] a couple of i

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110304171353.GU22723@ZenIV.linux.org.uk>
Date:	Fri, 4 Mar 2011 17:13:53 +0000
From:	Al Viro <viro@...IV.linux.org.uk>
To:	chris.mason@...cle.com
Cc:	linux-kernel@...r.kernel.org, linux-btrfs@...r.kernel.org
Subject: [RFC] a couple of i_nlink fixes in btrfs

	a) rename() plays with i_nlink of old_inode; bad, since it's not
locked.  I'd add a variant of btrfs_unlink_inode() that would leave
btrfs_drop_nlink()/btrfs_update_inode() to callers and use it instead.
	b) btrfs_link() doesn't check for i_nlink overflows.  I don't
know if there's anything preventing that many links to a file on btrfs,
but if there is, it's at least worth a comment in there...

	Please, review; patches in followups or in #btrfs in vfs-2.6.git
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/