linux-kernel - Re: [PATCH -v2] x86: early_quirk check all bus/dev/func in domain 0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110304102012.3ef9e7b2@jbarnes-desktop>
Date:	Fri, 4 Mar 2011 10:20:12 -0800
From:	Jesse Barnes <jbarnes@...tuousgeek.org>
To:	Yinghai Lu <yinghai@...nel.org>
Cc:	Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...e.hu>,
	"H. Peter Anvin" <hpa@...or.com>,
	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -v2] x86: early_quirk check all bus/dev/func in domain 0

On Mon, 07 Feb 2011 14:14:52 -0800
Yinghai Lu <yinghai@...nel.org> wrote:

> 
> When we have 00:1a.0, 00:1a.1, 00:1a.2, 00:1a.7
> Found only 00:1a.0, and 00:1a.1 get processed. and 00:1a.2 and 00:1a.7 get skipped.
> 
> We should only check header type on func0.
> Also should not bail out when have gap.
> 
> At last try to process bus 00 - 0xff instead of only bus 00.
> 
> -v2: check with VENDOR_ID instead of CLASS_DEVICE for invalid device.
> 
> Signed-off-by: Yinghai Lu <yinghai@...nel.org>

I need a much better changelog here.  It sounds (and looks) like the
patch is doing several things:
  - processing more than the first two functions on a device
  - processing the full set of busses in the first domain
  - checking for nonexistent devices

Why are you making these changes?  Do you have a system that needs
early quirks but violates the existing assumptions?  Can you apply a
standard quirk instead?

-- 
Jesse Barnes, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/