linux-kernel - Re: [PATCH 1/1] x86: Fix mcheck_init_device() to handle misc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110304181749.GA3469@bicker>
Date:	Fri, 4 Mar 2011 21:17:49 +0300
From:	Dan Carpenter <error27@...il.com>
To:	"J.P. Lacerda" <jp.lacerda@...ethink.co.uk>
Cc:	akpm@...ux-foundation.org, johan.wessfeldt@...il.com,
	tglx@...utronix.de, mingo@...hat.com, x86@...nel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] x86: Fix mcheck_init_device() to handle
 misc_register() correctly

On Fri, Mar 04, 2011 at 01:29:27PM +0000, J.P. Lacerda wrote:
> The return value for misc_register() was not being taken into account.
> Furthermore, if misc_register() fails, we must rollback any changes made by
> mcheck_init_device()
> 
> Signed-off-by: J.P. Lacerda <jp.lacerda@...ethink.co.uk>

Ah...  You found a bug that Johan missed in his original patch.  But you
still left out the case where mce_create_device() can fail which his 
patch addressed.  Also his patch was nicer; using gotos to unwind is 
the standard way for kernel error handling.

Also why did you poach his patch without giving any kind of credit,
instead of just telling him about the bug???  WTF?

Johan, please fix add a free_cpumask_var(mce_dev_initialized); to your
patch.  Call it [PATCH v2].  Add in the changelog that J.P. Lacerda
told you about the missing free_cpumask_var(mce_dev_initialized).

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/