lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 4 Mar 2011 10:10:40 +0530 From: "TK, Pratheesh Gangadhar" <pratheesh@...com> To: Arnd Bergmann <arnd@...db.de> CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "hjk@...sjkoch.de" <hjk@...sjkoch.de>, "gregkh@...e.de" <gregkh@...e.de>, "tglx@...utronix.de" <tglx@...utronix.de>, "sshtylyov@...sta.com" <sshtylyov@...sta.com>, "Chatterjee, Amit" <amit.chatterjee@...com>, "davinci-linux-open-source@...ux.davincidsp.com" <davinci-linux-open-source@...ux.davincidsp.com>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org> Subject: RE: [PATCH v9 1/1] PRUSS UIO driver support Hi, > -----Original Message----- > From: TK, Pratheesh Gangadhar > Sent: Friday, March 04, 2011 8:55 AM > > > +struct uio_pruss_dev { > > > + struct uio_info *info; > > > + struct clk *pruss_clk; > > > + dma_addr_t sram_paddr; > > > + dma_addr_t ddr_paddr; > > > + void __iomem *prussio_vaddr; > > > + void *sram_vaddr; > > > + void *ddr_vaddr; > > > + unsigned int hostirq_start; > > > + unsigned int pintc_base; > > > +}; > > > + > > > +struct pruss_priv { > > > + struct uio_pruss_dev *pupdev; > > > +}; > > > > I cannot see the point of struct pruss_priv, I think it would be better > to > > just merge the two data structures into one. Everything else looks > > good to me now. > > pruss_priv is needed to get access to uio_pruss_dev from uio_info *info in > UIO interrupt handler (pruss_handler) and shall be per interrupt entry. > > +static irqreturn_t pruss_handler(int irq, struct uio_info *info) { > + struct pruss_priv *priv = info->priv; > + struct uio_pruss_dev *gdev = priv->pupdev; > > Note that info is a pointer to array supporting 8 interrupts. This allows > to > redirect to driver structure via info->priv quickly. > I get your point, no need of additional structure here, can directly assign uio_pruss_dev pointer to info->priv. Will resubmit with this change. Thanks, Pratheesh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists