linux-kernel - Re: [PATCH 2/3] ptp: add a software clock based on clock_monotonic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 4 Mar 2011 07:42:51 +0100
From:	Richard Cochran <richardcochran@...il.com>
To:	Torben Hohn <torbenh@....de>
Cc:	linux-kernel@...r.kernel.org, richard.cochran@...cron.at,
	johnstul@...ibm.com, tglx@...utronix.de
Subject: Re: [PATCH 2/3] ptp: add a software clock based on
 clock_monotonic_raw

On Thu, Mar 03, 2011 at 06:26:13PM +0100, Torben Hohn wrote:
> +config PTP_1588_CLOCK_SOFTWARE
> +	tristate "software PTP clock"
> +	depends on PTP_1588_CLOCK
> +	help
> +	  This driver adds a software PTP clock. 

As John said, this needs a longer description. You can look back at
my V6 as an example.

  https://lkml.org/lkml/2010/9/23/220

> +static int ptp_ixp_adjfreq(struct ptp_clock_info *ptp, s32 ppb)

Once again, please rename.

Better yet, why not just use the V6 example instead?  If we are going
to have a testing driver, then I would want the simulated ancillary
code as well.

> +
> +static struct ptp_clock_info ptp_ixp_caps = {
> +	.owner		= THIS_MODULE,
> +	.name		= "software timer",
> +	.max_adj	= 66666655,

You should calculate the actual limit of adjustment and use it here.

Thanks,

Richard



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/