linux-kernel - Re: [patch] x86, mm: Clean up initmem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110304070802.GA27618@elte.hu>
Date:	Fri, 4 Mar 2011 08:08:02 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	David Rientjes <rientjes@...gle.com>
Cc:	Yinghai Lu <yinghai@...nel.org>,
	Cyrill Gorcunov <gorcunov@...il.com>,
	Tejun Heo <tj@...nel.org>, Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>, tglx@...utronix.de,
	brgerst@...il.com, shaohui.zheng@...el.com,
	linux-kernel@...r.kernel.org
Subject: Re: [patch] x86, mm: Clean up initmem_init


* David Rientjes <rientjes@...gle.com> wrote:

> On Thu, 3 Mar 2011, Yinghai Lu wrote:
> 
> > he want
> > 
> > > +#ifdef CONFIG_ACPI_NUMA
> > >> > +		ret = numa_init(x86_acpi_numa_init);
> > >> > +		if (!ret)
> > >> > +			return;
> > >> > +#endif
> > >> > +#ifdef CONFIG_AMD_NUMA
> > >> > +		ret = numa_init(amd_numa_init);
> > >> > +		if (!ret)
> > >> > +			return;
> > >> > +#endif
> > 
> > to be replaced by:
> > 
> > > +#ifdef CONFIG_ACPI_NUMA
> > >> > +		if (!numa_init(x86_acpi_numa_init))
> > >> > +			return;
> > >> > +#endif
> > >> > +#ifdef CONFIG_AMD_NUMA
> > >> > +		if (!numa_init(amd_numa_init))
> > >> > +			return;
> > >> > +#endif
> 
> It's a matter of style and I think it's up to Ingo what he'd prefer to 
> see.

I think your variant is cleaner: hiding function call side-effects in conditionscan 
be a fragile thing to do. We want constant expressions with no side-effects - so if 
functions are called they should be constant functions as well.

Code compactness isn't everything - if it was we'd be using C to the max to create 
unreadable compound expressions all the time.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/