| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Sat, 5 Mar 2011 11:00:35 +0100 From: Sedat Dilek <sedat.dilek@...glemail.com> To: Marco Stornelli <marco.stornelli@...il.com> Cc: Linux Kernel <linux-kernel@...r.kernel.org>, Linux FS Devel <linux-fsdevel@...r.kernel.org> Subject: Re: [PATCH v3] Check for immutable/append flag in fallocate path On 3/5/11, Marco Stornelli <marco.stornelli@...il.com> wrote: > From: Marco Stornelli <marco.stornelli@...il.com> > > In the fallocate path the kernel doesn't check for the immutable/append > flag. It's possible to have a race condition in this scenario: an > application open a file in read/write and it does something, meanwhile > root set the immutable flag on the file, the application at that point > can call fallocate with success. In addition, we don't allow to do any > unreserve operation on an append only file but only the reserve one. > > Signed-off-by: Marco Stornelli <marco.stornelli@...il.com> > --- > Patch is against 2.6.38-rc7 > > ChangeLog: > v3: Modified do_fallocate instead of every single fs > v2: Added the check for append-only file for XFS > v1: First draft > > --- open.c.orig 2011-03-01 22:55:12.000000000 +0100 > +++ open.c 2011-03-04 15:28:43.000000000 +0100 Shouldn't that be sth like...? --- linux-2.6.38-rc7.orig/fs/open.c +++ linux-2.6.38-rc7/fs/open.c - Sedat - -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists