linux-kernel - Re: [RFC PATCH] net/core: fix skb handling on netif serves for both bridge and vlan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110305103613.GB7799@psychotron.redhat.com>
Date:	Sat, 5 Mar 2011 11:36:14 +0100
From:	Jiri Pirko <jpirko@...hat.com>
To:	Xiaotian Feng <dfeng@...hat.com>
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <eric.dumazet@...il.com>,
	Tom Herbert <therbert@...gle.com>
Subject: Re: [RFC PATCH] net/core: fix skb handling on netif serves for both
 bridge and vlan

Thu, Mar 03, 2011 at 11:55:13AM CET, dfeng@...hat.com wrote:
>Consider network topology as follows:
>
>eth0  eth1
> |_____|
>    |
>  bond0 --- br0
>    |
>  vlan0 --- br1
>
>bond0 serves for both br0 and vlan0, if a vlan tagged packet was sent
>to br1 through bond0, bridge handling code is seeing the packet on bond0
>and handing it off to my "legacy" bridge before vlan_tx_tag_present
>and vlan_hwaccel_do_receive even haven't a chance to look at it.
>
>Moving the vlan_tx_tag_present before bridge/macvlan handling code could
>cure this.

Wouldn't this break "eth0 - br0 - br0.5"?

>
>Signed-off-by: Xiaotian Feng <dfeng@...hat.com>
>Cc: "David S. Miller" <davem@...emloft.net>
>Cc: Eric Dumazet <eric.dumazet@...il.com>
>Cc: Tom Herbert <therbert@...gle.com>
>---
> net/core/dev.c |   20 ++++++++++----------
> 1 files changed, 10 insertions(+), 10 deletions(-)
>
>diff --git a/net/core/dev.c b/net/core/dev.c
>index 8ae6631..d2d12c2 100644
>--- a/net/core/dev.c
>+++ b/net/core/dev.c
>@@ -3079,27 +3079,27 @@ static int __netif_receive_skb(struct sk_buff *skb)
> ncls:
> #endif
> 
>-	/* Handle special case of bridge or macvlan */
>-	rx_handler = rcu_dereference(skb->dev->rx_handler);
>-	if (rx_handler) {
>+	if (vlan_tx_tag_present(skb)) {
> 		if (pt_prev) {
> 			ret = deliver_skb(skb, pt_prev, orig_dev);
> 			pt_prev = NULL;
> 		}
>-		skb = rx_handler(skb);
>-		if (!skb)
>+		if (vlan_hwaccel_do_receive(&skb)) {
>+			ret = __netif_receive_skb(skb);
>+			goto out;
>+		} else if (unlikely(!skb))
> 			goto out;
> 	}
> 
>-	if (vlan_tx_tag_present(skb)) {
>+	/* Handle special case of bridge or macvlan */
>+	rx_handler = rcu_dereference(skb->dev->rx_handler);
>+	if (rx_handler) {
> 		if (pt_prev) {
> 			ret = deliver_skb(skb, pt_prev, orig_dev);
> 			pt_prev = NULL;
> 		}
>-		if (vlan_hwaccel_do_receive(&skb)) {
>-			ret = __netif_receive_skb(skb);
>-			goto out;
>-		} else if (unlikely(!skb))
>+		skb = rx_handler(skb);
>+		if (!skb)
> 			goto out;
> 	}
> 
>-- 
>1.7.1
>
>--
>To unsubscribe from this list: send the line "unsubscribe netdev" in
>the body of a message to majordomo@...r.kernel.org
>More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/