linux-kernel - Re: [PATCHv2 02/24] sys_swapon: remove changelog from function comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1103052008510.32044@swampdragon.chaosbits.net>
Date:	Sat, 5 Mar 2011 20:11:29 +0100 (CET)
From:	Jesper Juhl <jj@...osbits.net>
To:	Cesar Eduardo Barros <cesarb@...arb.net>
cc:	linux-mm@...ck.org, Andrew Morton <akpm@...ux-foundation.org>,
	Hugh Dickins <hughd@...gle.com>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>,
	Minchan Kim <minchan.kim@...il.com>,
	Jens Axboe <jaxboe@...ionio.com>, linux-kernel@...r.kernel.org,
	Eric B Munson <emunson@...bm.net>
Subject: Re: [PATCHv2 02/24] sys_swapon: remove changelog from function
 comment

On Sat, 5 Mar 2011, Cesar Eduardo Barros wrote:

> Changelogs belong in the git history instead of in the source code.
> 
> Also, "The swapon system call" is redundant with
> "SYSCALL_DEFINE2(swapon, ...)".
> 
> Signed-off-by: Cesar Eduardo Barros <cesarb@...arb.net>
> Tested-by: Eric B Munson <emunson@...bm.net>
> Acked-by: Eric B Munson <emunson@...bm.net>
> ---
>  mm/swapfile.c |    5 -----
>  1 files changed, 0 insertions(+), 5 deletions(-)
> 
> diff --git a/mm/swapfile.c b/mm/swapfile.c
> index 3fe8913..75ee39c 100644
> --- a/mm/swapfile.c
> +++ b/mm/swapfile.c
> @@ -1844,11 +1844,6 @@ static int __init max_swapfiles_check(void)
>  late_initcall(max_swapfiles_check);
>  #endif
>  
> -/*
> - * Written 01/25/92 by Simmule Turner, heavily changed by Linus.
> - *
> - * The swapon system call
> - */

Second line in the comment can hardly be called "changelog".

Removing the comment won't break anything, so

Reviewed-by: Jesper Juhl <jj@...osbits.net>

-- 
Jesper Juhl <jj@...osbits.net>            http://www.chaosbits.net/
Plain text mails only, please.
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/