linux-kernel - Re: [PATCH 1/3] msm: Add support for Scorpion and ScorpionMP PMU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <abd1b409d545d4a3c24e4f0dedf56c6f.squirrel@www.codeaurora.org>
Date:	Sat, 5 Mar 2011 13:18:50 -0800 (PST)
From:	"Sheetal Sahasrabudhe" <sheetals@...eaurora.org>
To:	"Trilok Soni" <tsoni@...eaurora.org>
Cc:	"Sheetal Sahasrabudhe" <sheetals@...eaurora.org>,
	linux-arm-kernel@...ts.infradead.org, will.deacon@....com,
	dwalker@...o99.com, bryanh@...eaurora.org, davidb@...eaurora.org,
	linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] msm: Add support for Scorpion and ScorpionMP PMU

Hi Trilok,

>> +static int __init scorpion_pmu_init(void)
>> +{
>> +	platform_device_register(&pmu_device);
>
> platform_device_register can fail. Better do it like
>
> "return platform_device_register(&pmu_device);

Good catch, I will update it.

Thanks,
Sheetal

-- 
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/