linux-kernel - Re: [PATCH] [media] dib0700: get rid of on-stack dma buffers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110306153805.001011a9@schatten.dmk.lab>
Date:	Sun, 6 Mar 2011 15:38:05 +0100
From:	Florian Mickler <florian@...kler.org>
To:	Oliver Neukum <oliver@...kum.org>
Cc:	mchehab@...radead.org, linux-media@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	"Greg Kroah-Hartman" <greg@...ah.com>,
	"Rafael J. Wysocki" <rjw@...k.pl>,
	Maciej Rutecki <maciej.rutecki@...il.com>
Subject: Re: [PATCH] [media] dib0700: get rid of on-stack dma buffers

On Sun, 6 Mar 2011 13:06:09 +0100
Oliver Neukum <oliver@...kum.org> wrote:

> Am Sonntag, 6. März 2011, 12:16:52 schrieb Florian Mickler:
> > This should fix warnings seen by some:
> > 	WARNING: at lib/dma-debug.c:866 check_for_stack
> > 
> > Fixes: https://bugzilla.kernel.org/show_bug.cgi?id=15977.
> > Reported-by: Zdenek Kabelac <zdenek.kabelac@...il.com>
> > Signed-off-by: Florian Mickler <florian@...kler.org>
> > CC: Mauro Carvalho Chehab <mchehab@...radead.org>
> > CC: linux-media@...r.kernel.org
> > CC: linux-kernel@...r.kernel.org
> > CC: Greg Kroah-Hartman <greg@...ah.com>
> > CC: Rafael J. Wysocki <rjw@...k.pl>
> > CC: Maciej Rutecki <maciej.rutecki@...il.com>
> > ---
> > 
> > Please take a look at it, as I do not do that much kernel hacking
> > and don't wanna brake anybodys computer... :)
> > 
> > From my point of view this should _not_ go to stable even though it would
> > be applicable. But if someone feels strongly about that and can
> > take responsibility for that change...
> 
> The patch looks good and is needed in stable.
> It could be improved by using a buffer allocated once in the places
> you hold a mutex anyway.
> 
> 	Regards
> 		Oliver

Ok, I now put a buffer member in the priv dib0700_state which gets
allocated on the heap. 

My patch introduces a new error condition in the dib0700_identify_state
callback which gets not checked for in dvb_usb_find_device... 
Should we worry?

Same for dib0700_get_version in the probe callback...
But there, there was already the possibility of usb_control_msg
returning an error...

Regards,
Flo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/