[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <4D749D70.1020106@redhat.com>
Date: Mon, 07 Mar 2011 10:55:12 +0200
From: Avi Kivity <avi@...hat.com>
To: Xiao Guangrong <xiaoguangrong@...fujitsu.com>
CC: Marcelo Tosatti <mtosatti@...hat.com>,
LKML <linux-kernel@...r.kernel.org>, KVM <kvm@...r.kernel.org>
Subject: Re: [PATCH 2/10] KVM: MMU: fix kvm_mmu_get_spte_hierarchy
On 03/07/2011 05:06 AM, Xiao Guangrong wrote:
> We can get the large mapping pte in the loop:
>
> static bool shadow_walk_okay(struct kvm_shadow_walk_iterator *iterator)
> {
> if (iterator->level< PT_PAGE_TABLE_LEVEL)
> return false;
>
> if (iterator->level == PT_PAGE_TABLE_LEVEL)
> if (is_large_pte(*iterator->sptep))
> return false;
>
> ......
> }
>
> if level> 1 and pte.pse is set, it will return true.
>
> And, i think this judgment is useless:
> if (iterator->level == PT_PAGE_TABLE_LEVEL)
> if (is_large_pte(*iterator->sptep))
> return false;
> since if level = 1, the pte bit7 is PAT.
Right, the logic is inverted. I'll fix it up.
--
error compiling committee.c: too many arguments to function
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists