linux-kernel - RE: [PATCH 3/5] mfd: free dangling irq in ab8500 gpadc probe error path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <757395B8DE5A844B80F3F4BE9867DDB64FAF4FA2AA@EXDCVYMBSTM006.EQ1STM.local>
Date:	Mon, 7 Mar 2011 10:13:55 +0100
From:	Daniel WILLERUD <daniel.willerud@...ricsson.com>
To:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 3/5] mfd: free dangling irq in ab8500 gpadc probe error
 path

Acked-by: Daniel Willerud <daniel.willerud@...ricsson.com>

-----Original Message-----
From: Linus WALLEIJ 
Sent: den 5 mars 2011 11:46
To: Samuel Ortiz; linux-kernel@...r.kernel.org
Cc: Lee Jones; Daniel WILLERUD; Linus Walleij
Subject: [PATCH 3/5] mfd: free dangling irq in ab8500 gpadc probe error path

From: Daniel Willerud <daniel.willerud@...ricsson.com>

Signed-off-by: Daniel Willerud <daniel.willerud@...ricsson.com>
Signed-off-by: Linus Walleij <linus.walleij@...aro.org>
---
 drivers/mfd/ab8500-gpadc.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/drivers/mfd/ab8500-gpadc.c b/drivers/mfd/ab8500-gpadc.c
index 178cbc5..b5b75b7 100644
--- a/drivers/mfd/ab8500-gpadc.c
+++ b/drivers/mfd/ab8500-gpadc.c
@@ -267,11 +267,13 @@ static int __devinit ab8500_gpadc_probe(struct platform_device *pdev)
 	if (IS_ERR(gpadc->regu)) {
 		ret = PTR_ERR(gpadc->regu);
 		dev_err(gpadc->dev, "failed to get vtvout LDO\n");
-		goto fail;
+		goto fail_irq;
 	}
 	list_add_tail(&gpadc->node, &ab8500_gpadc_list);
 	dev_dbg(gpadc->dev, "probe success\n");
 	return 0;
+fail_irq:
+	free_irq(gpadc->irq, gpadc);
 fail:
 	kfree(gpadc);
 	gpadc = NULL;
-- 
1.7.3.2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/