| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20110307221129.GC14789@ericsson.com> Date: Mon, 7 Mar 2011 14:11:29 -0800 From: Guenter Roeck <guenter.roeck@...csson.com> To: Greg Schnorr <gschnorr@...co.com> CC: Jean Delvare <khali@...ux-fr.org>, Jonathan Cameron <kernel@...23.retrosnub.co.uk>, Randy Dunlap <rdunlap@...otime.net>, "lm-sensors@...sensors.org" <lm-sensors@...sensors.org>, "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] hwmon: (pmbus) More stringent checking of VOUT_MODE register On Mon, Mar 07, 2011 at 04:44:43PM -0500, Greg Schnorr wrote: > Looks good, tested and works on one such VOUT_MODE poor design... > > On 3/1/11 9:32 PM, "Guenter Roeck" <guenter.roeck@...csson.com> wrote: > > > Some PMBus chips do not support the VOUT_MODE register. To make matters worse, > > such chips may not return an error when reading the register either, but > > instead > > return 0xff. > > > > Check if the register exists using pmbus_check_byte_register() before reading > > its value. In addition, validate the returned value and ignore it if it is > > 0xff > > (which is invalid). > > > > Reported-by: Greg Schnorr <gschnorr@...co.com> > > Signed-off-by: Guenter Roeck <guenter.roeck@...csson.com> > Acked-by: Greg Schnorr <gschnorr@...co.com> > Thanks! Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists