linux-kernel - Re: [PATCH 05/10] block: remove per-queue plugging

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1299577122.2308.1201.camel@twins>
Date:	Tue, 08 Mar 2011 10:38:42 +0100
From:	Peter Zijlstra <peterz@...radead.org>
To:	Jens Axboe <jaxboe@...ionio.com>
Cc:	Mike Snitzer <snitzer@...hat.com>, Shaohua Li <shli@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"hch@...radead.org" <hch@...radead.org>,
	Ingo Molnar <mingo@...e.hu>
Subject: Re: [PATCH 05/10] block: remove per-queue plugging

On Mon, 2011-03-07 at 21:46 +0100, Jens Axboe wrote:
> 
> Great, that'll work for me! Your patch should work as-is, then. Thanks
> Peter.

Well I think it would be good to write it like:

  if (prev->state != TASK_RUNNING && blkneeds_flush(prev)) {
    raw_spin_unlock(&rq->lock);
    blk_flush_plug(prev);
    raw_spin_lock(&rq->lock);
  }

To avoid flipping that lock when we don't have to.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/