linux-kernel - Re: [PATCH/RFC v2 1/3] Shared BCH ECC library

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1299587825.2754.30.camel@localhost>
Date:	Tue, 08 Mar 2011 14:37:05 +0200
From:	Artem Bityutskiy <dedekind1@...il.com>
To:	Ivan Djelic <ivan.djelic@...rot.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	linux-mtd@...ts.infradead.org
Subject: Re: [PATCH/RFC v2 1/3] Shared BCH ECC library

Well, I can put these to my l2-mtd-2.6 tree and l
On Mon, 2011-02-07 at 15:09 +0100, Ivan Djelic wrote:
>  #
> +# BCH support is selected if needed
> +#
> +# If the BCH library is always used with the same parameters
> +# m and t, you may select option BCH_CONST_PARAMS and provide
> +# default values for symbols BCH_CONST_M and BCH_CONST_T in
> +# your Kconfig code. This will enable extra compiler optimizations
> +# and provide better (up to 2x) encoding performance for small
> +# values of t, at the expense of supporting only a single (m,t)
> +# configuration.
> +#
> +config BCH
> +	tristate
> +
> +config BCH_CONST_PARAMS
> +	boolean
> +
> +config BCH_CONST_M
> +	int
> +	range 5 15
> +
> +config BCH_CONST_T
> +	int

Could you please re-work this and add useful "help" description to each
of these. You added some description to the comments, but it really
should be in the help text instead, may be even in a bit more verbose
form.

-- 
Best Regards,
Artem Bityutskiy (Артём Битюцкий)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/