linux-kernel - Re: [PATCH] x86: Fix ACPI wakeup build failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1299623554.6915.1427615977@webmail.messagingengine.com>
Date:	Tue, 08 Mar 2011 23:32:34 +0100
From:	"Alexander van Heukelum" <heukelum@...tmail.fm>
To:	"Sedat Dilek" <sedat.dilek@...glemail.com>
Cc:	"Sedat Dilek" <sedat.dilek@...il.com>,
	"H.J. Lu" <hjl.tools@...il.com>, "Len Brown" <len.brown@...el.com>,
	"Pavel Machek" <pavel@....cz>, "Rafael J. Wysocki" <rjw@...k.pl>,
	"Thomas Gleixner" <tglx@...utronix.de>,
	"Ingo Molnar" <mingo@...hat.com>, "H. Peter Anvin" <hpa@...or.com>,
	x86@...nel.org, linux-pm@...ts.linux-foundation.org,
	linux-kernel@...r.kernel.org, linux-next@...r.kernel.org
Subject: Re: [PATCH] x86: Fix ACPI wakeup build failure

On Tue, 08 Mar 2011 22:39 +0100, "Sedat Dilek" <sedat.dilek@...glemail.com> wrote:
> This fixes the following breakage in linux-next (next-20110308):
>   AS      arch/x86/kernel/acpi/wakeup_rm.o
>   arch/x86/kernel/acpi/wakeup_rm.S: Assembler messages:
>   arch/x86/kernel/acpi/wakeup_rm.S:12: Error: .size expression with
>   symbol `wakeup_code_start' does not evaluate to a constant
> 
> The issue was introduced by commit
> d1ee433539ea5963a8f946f3428b335d1c5fdb20:
> "x86, trampoline: Use the unified trampoline setup for ACPI wakeup"
> 
> The problem was discovered while using Debian's binutils
> (2.21.0.20110302-1)
> and experimenting with binutils from upstream.
> 
> Thanks Alexander and H.J. for the vital help.
> 
> CC: Alexander van Heukelum <heukelum@...tmail.fm>
> CC: "H.J. Lu" <hjl.tools@...il.com>
> CC: Len Brown <len.brown@...el.com>
> CC: Pavel Machek <pavel@....cz>
> CC: "Rafael J. Wysocki" <rjw@...k.pl>
> CC: Thomas Gleixner <tglx@...utronix.de>
> CC: Ingo Molnar <mingo@...hat.com>
> CC: "H. Peter Anvin" <hpa@...or.com>
> CC: x86@...nel.org
> CC: linux-pm@...ts.linux-foundation.org
> CC: linux-kernel@...r.kernel.org
> CC: linux-next@...r.kernel.org
> Signed-off-by: Sedat Dilek <sedat.dilek@...il.com>

Acked-by: Alexander van Heukelum <heukelum@...tmail.fm>

(This problem exists in the x86-tree. Mainline is fine.)

> ---
>  arch/x86/kernel/acpi/wakeup_rm.S |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/x86/kernel/acpi/wakeup_rm.S
> b/arch/x86/kernel/acpi/wakeup_rm.S
> index 6ce81ee..63b8ab5 100644
> --- a/arch/x86/kernel/acpi/wakeup_rm.S
> +++ b/arch/x86/kernel/acpi/wakeup_rm.S
> @@ -9,4 +9,4 @@
>  	.globl	acpi_wakeup_code
>  acpi_wakeup_code:
>  	.incbin	"arch/x86/kernel/acpi/realmode/wakeup.bin"
> -       .size   wakeup_code_start, .-wakeup_code_start
> +       .size   acpi_wakeup_code, .-acpi_wakeup_code
> -- 
> 1.7.4.1
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/