linux-kernel - Re: mce.c related WARNING: at kernel/timer.c:983 del_timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTi=7S60UjieW0_ZhX7F5gm39+c28Bdv=dRhPd=tQ@mail.gmail.com>
Date:	Tue, 8 Mar 2011 17:06:56 +0800
From:	Yong Zhang <yong.zhang0@...il.com>
To:	Venkatesh Pallipadi <venki@...gle.com>
Cc:	Andi Kleen <andi@...stfloor.org>,
	Yong Zhang <yong.zhang@...driver.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...e.hu>, "H. Peter Anvin" <hpa@...or.com>
Subject: Re: mce.c related WARNING: at kernel/timer.c:983 del_timer_sync

On Tue, Mar 8, 2011 at 9:31 AM, Venkatesh Pallipadi <venki@...gle.com> wrote:
> With latest git kernel, I see the below WARN_ON at boot, once for each CPU.
>
> [   26.806429] ------------[ cut here ]------------
> [   26.806434] WARNING: at kernel/timer.c:983 del_timer_sync+0x39/0x4d()
> [   26.806437] Hardware name: MCP55
> [   26.806438] Modules linked in: tg3 forcedeth sata_mv powernow_k8
> freq_table processor mperf msr cpuid ipv6 genrtc
> [   26.806447] Pid: 0, comm: swapper Tainted: G        W
> 2.6.38-smp-linus.22280 #23
> [   26.806449] Call Trace:
> [   26.806450]  <IRQ>  [<ffffffff8106e8ea>] ? warn_slowpath_common+0x85/0x9d
> [   26.806456]  [<ffffffff8106e91c>] ? warn_slowpath_null+0x1a/0x1c
> [   26.806459]  [<ffffffff8107ac48>] ? del_timer_sync+0x39/0x4d
> [   26.806462]  [<ffffffff81047a44>] ? mce_cpu_restart+0x1e/0x54
> [   26.806466]  [<ffffffff81099b22>] ?
> generic_smp_call_function_single_interrupt+0xd1/0xf3
> [   26.806469]  [<ffffffff8104c188>] ?
> smp_call_function_single_interrupt+0x18/0x27
> [   26.806473]  [<ffffffff810375f3>] ? call_function_single_interrupt+0x13/0x20
> [   26.806475]  <EOI>  [<ffffffff8103da93>] ? default_idle+0x4d/0x7f
> [   26.806479]  [<ffffffff8103da73>] ? default_idle+0x2d/0x7f
> [   26.806482]  [<ffffffff8103dbad>] ? c1e_idle+0xe8/0xef
> [   26.806485]  [<ffffffff8145bc62>] ? atomic_notifier_call_chain+0x18/0x1a
> [   26.806488]  [<ffffffff81035cc7>] ? cpu_idle+0x5f/0x96
> [   26.806491]  [<ffffffff8144af7e>] ? rest_init+0x72/0x74
> [   26.806495]  [<ffffffff818edcfe>] ? start_kernel+0x37b/0x386
> [   26.806498]  [<ffffffff818ed2a4>] ? x86_64_start_reservations+0xb4/0xb8
> [   26.806502]  [<ffffffff818ed39a>] ? x86_64_start_kernel+0xf2/0xf9
> [   26.806504] ---[ end trace 69a4de56993e518a ]---
>
> Looks like WARN_ON was after this change
> commit 466bd3030973910118ca601da8072be97a1e2209
> Author: Yong Zhang <yong.zhang@...driver.com>
> Date:   Wed Oct 20 15:57:33 2010 -0700
>
>    timer: Warn when del_timer_sync() is called in hardirq context

Even if without the WARN_ON(), lockdep will shout on it :)

>
> But, the actual reason is likely some MCE parameter change at boot causing
> mce_restart() which in turn calls on_each_cpu mce_cpu_restart() which calls
> del_timer_sync().

Seems we found a real bug.

And usage of del_timer_sync() in arch/x86/kernel/cpu/mcheck/mce.c
break two restriction:
1) del_timer_sync() must not be used in interrupt context;
2) The timer's handler must not call add_timer_on();

Thanks,
Yong

-- 
Only stand for myself
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/