[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <AANLkTikfQGZwXj52ew1Zh9gc+YeLxevivaBocx8_uOz-@mail.gmail.com>
Date: Wed, 9 Mar 2011 09:01:17 +0900
From: Minkyu Kang <promsoft@...il.com>
To: Dave Jones <davej@...hat.com>, Minkyu Kang <mk7.kang@...sung.com>,
linux-kernel@...r.kernel.org, linux-i2c@...r.kernel.org,
Greg KH <greg@...ah.com>,
Andrew Morton <akpm@...ux-foundation.org>,
kyungmin.park@...sung.com, Ben Dooks <ben-i2c@...ff.org>
Subject: Re: [PATCH v3] misc: adds support the FSA9480 USB Switch
Dear Dave Jones,
On 9 March 2011 06:02, Dave Jones <davej@...hat.com> wrote:
> On Tue, Mar 08, 2011 at 03:56:56PM +0900, Minkyu Kang wrote:
>
> > +static DEVICE_ATTR(switch, S_IRUGO | S_IWUGO,
> > + fsa9480_show_manualsw, fsa9480_set_manualsw);
>
> This probably shouldn't be world writable if it's writing to hardware.
>
It can be used in user space.
Thanks
Minkyu Kang
--
from. prom.
www.promsoft.net
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists