linux-kernel - Re: [PATCH 3/4] hid-multitouch: migrate 3M PCT touch screens to the unified driver.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110309094748.GB3980@polaris.bitmath.org>
Date:	Wed, 9 Mar 2011 10:47:48 +0100
From:	"Henrik Rydberg" <rydberg@...omail.se>
To:	Benjamin Tissoires <benjamin.tissoires@...c.fr>
Cc:	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Jiri Kosina <jkosina@...e.cz>,
	Stephane Chatty <chatty@...-enac.fr>,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/4] hid-multitouch: migrate 3M PCT touch screens to the
 unified driver.

On Wed, Mar 09, 2011 at 10:13:55AM +0100, Benjamin Tissoires wrote:
> Hi Henrik
> 
> On Wed, Mar 9, 2011 at 09:46, Henrik Rydberg <rydberg@...omail.se> wrote:
> > Hi Benjamin,
> >
> > On Tue, Mar 08, 2011 at 05:32:58PM +0100, Benjamin Tissoires wrote:
> >> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@...c.fr>
> >> ---
> >
> > Semms this patch is missing a commit message.
> 
> You can copy/paste this point to the other patches as well.
> 
> How about:
> "3M PCT touch screens can be handled by the unified driver. This will
> ease future evolution. So, just move it."
> 
> Then I'll copy/paste for the others.

I bet every driver merge has its own considerations that deserve
comment. A good commit message gives an introduction to the code
change and gives some context to the reader. Richard made a nice one
for the egalax driver.

Henrik
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/