linux-kernel - Re: [PATCH] stable: sheevaplug-setup.c fix LED color name and add support for second LED This is a patch to the sheevaplug-setup.c file that fixes the color name of the existing health LED. That LED gpio 49 is green when off and blue when on. The pat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <AANLkTinydE-N2eVgq5aF4m31Asd8sWO2sNgO5tjcGDU6@mail.gmail.com>
Date:	Wed, 9 Mar 2011 16:16:41 +0200
From:	saeed bishara <saeed.bishara@...il.com>
To:	Robin Becker <replabrobin@...il.com>
Cc:	kernel@...tstofly.org, nico@...xnic.net, linux@....linux.org.uk,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	replabrobin <robin@...ortlab.com>
Subject: Re: [PATCH] stable: sheevaplug-setup.c fix LED color name and add
 support for second LED This is a patch to the sheevaplug-setup.c file that
 fixes the color name of the existing health LED. That LED gpio 49 is green
 when off and blue when on. The pat

On Wed, Mar 9, 2011 at 3:27 PM, Robin Becker <replabrobin@...il.com> wrote:
> From: replabrobin <robin@...ortlab.com>
please use short subject for this commit, and move the description
into the commit description section
aslo, I would split this to two patches, one fixes the LED color name,
the second for adding the new LED.

>  static unsigned int sheevaplug_mpp_config[] __initdata = {
>        MPP29_GPIO,     /* USB Power Enable */
> -       MPP49_GPIO,     /* LED */
> +       MPP46_GPIO,     /* RED LED */
> +       MPP49_GPIO,     /* BLUE LED */
>        0
>  };
>
>  static unsigned int sheeva_esata_mpp_config[] __initdata = {
>        MPP29_GPIO,     /* USB Power Enable */
>        MPP44_GPIO,     /* SD Write Protect */
> +       MPP46_GPIO,     /* RED LED */
>        MPP47_GPIO,     /* SD Card Detect */
>        MPP49_GPIO,     /* LED Green */
please fix the comment as well
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/