linux-kernel - Re: block: Fix oops caused by __blkdev_get() calling disk_unblock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 9 Mar 2011 19:59:09 +0100
From:	Tejun Heo <tj@...nel.org>
To:	Jens Axboe <jaxboe@...ionio.com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"kay.sievers@...y.org" <kay.sievers@...y.org>,
	"hch@...radead.org" <hch@...radead.org>
Subject: Re: block: Fix oops caused by __blkdev_get() calling
 disk_unblock_events() with invalid @disk

On Wed, Mar 09, 2011 at 07:26:44PM +0100, Jens Axboe wrote:
> >   This is fixed by moving reference putting after open success is
> >   determined and not clearing @disk to %NULL.  On success, @disk is
> >   valid because there is another opener holding reference to it.  On
> >   failure, the references are put after disk_unblock_events() is
> >   called.
> 
> Thanks, applied. A bit unfortunate to have a 100% crasher in the tree,
> though. Will suck for bisects.

Yeah, that does suck.  I folded in the fix to the offending commit and
regenerated the tree in case you want to rebase the tree.

  ssh://master.kernel.org/pub/scm/linux/kernel/git/tj/misc.git disk-event-convert-fixed

Thank you.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/