linux-kernel - Re: [Xen-devel] [PATCH R4 7/7] xen/balloon: Memory hotplug support for Xen balloon driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110309201403.GJ8049@dumpdata.com>
Date:	Wed, 9 Mar 2011 15:14:03 -0500
From:	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
To:	Daniel Kiper <dkiper@...-space.pl>
Cc:	ian.campbell@...rix.com, akpm@...ux-foundation.org,
	andi.kleen@...el.com, haicheng.li@...ux.intel.com,
	fengguang.wu@...el.com, jeremy@...p.org,
	dan.magenheimer@...cle.com, v.tolstov@...fip.ru, pasik@....fi,
	dave@...ux.vnet.ibm.com, wdauchy@...il.com, rientjes@...gle.com,
	xen-devel@...ts.xensource.com, linux-kernel@...r.kernel.org,
	linux-mm@...ck.org
Subject: Re: [Xen-devel] [PATCH R4 7/7] xen/balloon: Memory hotplug support
 for Xen balloon driver

> -		credit = current_target() - balloon_stats.current_pages;
> +		credit = current_credit();
>  
> -		if (credit > 0)
> -			state = increase_reservation(credit);
> +		if (credit > 0) {
> +			if (balloon_is_inflated())
> +				state = increase_reservation(credit);
> +			else
> +				state = reserve_additional_memory(credit);
> +		}

This code manipulation of where the current_target becomes current_credit
(and that logic) should be split off in its own patch.

Otherwise all the patches that touch Xen code look good.
>  
>  		if (credit < 0)
>  			state = decrease_reservation(-credit);
> @@ -458,6 +594,14 @@ static int __init balloon_init(void)
>  	balloon_stats.retry_count = 1;
>  	balloon_stats.max_retry_count = 16;
>  
> +#ifdef CONFIG_XEN_BALLOON_MEMORY_HOTPLUG
> +	balloon_stats.hotplug_pages = 0;
> +	balloon_stats.balloon_hotplug = 0;
> +
> +	register_online_page_notifier(&xen_online_page_nb);
> +	register_memory_notifier(&xen_memory_nb);
> +#endif
> +
>  	register_balloon(&balloon_sysdev);
>  
>  	/*
> -- 
> 1.5.6.5
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@...ts.xensource.com
> http://lists.xensource.com/xen-devel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/