linux-kernel - Re: [PATCH/RFC v3 1/3] Shared BCH ECC library

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1299762826.6676.10.camel@localhost>
Date:	Thu, 10 Mar 2011 15:13:46 +0200
From:	Artem Bityutskiy <dedekind1@...il.com>
To:	Ivan Djelic <ivan.djelic@...rot.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	"linux-mtd@...ts.infradead.org" <linux-mtd@...ts.infradead.org>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH/RFC v3 1/3] Shared BCH ECC library

On Wed, 2011-03-09 at 18:50 +0100, Ivan Djelic wrote:
> Hello,
> 
> The first patch of this series contains a new generic BCH ECC library.
> 
> This library can be used to provide software BCH correction on NAND devices
> (see 2nd and 3rd patch), as well as error correction for hybrid hardware BCH
> engines.
> 
> This version v3
> - improves Kconfig help description as suggested by Artem Bityutskiy
> - documents the public domain origin of a parity computation code snippet
> 
> Could you please review and comment ?
> Thanks,

I've put these patches to my l2-mtd-2.6 tree, let's see if dwmw2 merges
them. I doubt there are many people who'd wish to really review it, but
indeed the code looks good.

There are a couple of checkpatch.pl complaints for the 3rd patch, not
very important though. Also, I think nowadays we do not put file name in
the comments like you did:

+/*
+ * include/linux/bch.h
+ *

But again, not big deal. But it is better to address these tiny things,
anyway. If you re-send v4 - I'll put it to my tree instead of v3.

Thanks.

-- 
Best Regards,
Artem Bityutskiy (Артём Битюцкий)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/