linux-kernel - Re: [PATCH 1/3] msm: 8660: Add clock control regions to iomap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4D78F0D8.7000408@ru.mvista.com>
Date:	Thu, 10 Mar 2011 18:40:08 +0300
From:	Sergei Shtylyov <sshtylyov@...sta.com>
To:	Stephen Boyd <sboyd@...eaurora.org>
CC:	David Brown <davidb@...eaurora.org>,
	Daniel Walker <dwalker@...o99.com>,
	linux-arm-msm@...r.kernel.org,
	Saravana Kannan <skannan@...eaurora.org>,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 1/3] msm: 8660: Add clock control regions to iomap

Hello.

On 10-03-2011 7:44, Stephen Boyd wrote:

> Change-Id: I9e72f10d0da1d6aaaaf7df85d33b998edf424f6f

    This shouldn't be here.

> Signed-off-by: Stephen Boyd<sboyd@...eaurora.org>
[...]

> diff --git a/arch/arm/mach-msm/include/mach/msm_iomap-8x60.h b/arch/arm/mach-msm/include/mach/msm_iomap-8x60.h
> index 3b19b8f..ddfc85b 100644
> --- a/arch/arm/mach-msm/include/mach/msm_iomap-8x60.h
> +++ b/arch/arm/mach-msm/include/mach/msm_iomap-8x60.h
> @@ -53,6 +53,14 @@
>  #define MSM_TLMM_PHYS		0x00800000
>  #define MSM_TLMM_SIZE		SZ_16K
>
> +#define MSM_CLK_CTL_BASE        IOMEM(0xFA010000)
> +#define MSM_CLK_CTL_PHYS        0x00900000
> +#define MSM_CLK_CTL_SIZE        SZ_16K

    Surrounding code separates the macro names from values by tabs, and you're 
using spaces. Should be more consistent...

> +#define MSM_LPASS_CLK_CTL_BASE  IOMEM(0xFA015000)
> +#define MSM_LPASS_CLK_CTL_PHYS  0x28000000
> +#define MSM_LPASS_CLK_CTL_SIZE  SZ_4K
> +
>  #define MSM_SHARED_RAM_BASE	IOMEM(0xF0100000)
>  #define MSM_SHARED_RAM_SIZE	SZ_1M

WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/