linux-kernel - [PATCH] ipmi: Fix IPMI errors due to timing problems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-id: <1299787221-19542-1-git-send-email-minyard@acm.org>
Date:	Thu, 10 Mar 2011 14:00:21 -0600
From:	Corey Minyard <minyard@....org>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	OpenIPMI Developers <openipmi-developer@...ts.sourceforge.net>,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	YiCheng Doe <yicheng.doe@...com>,
	Tom Mingarelli <thomas.mingarelli@...com>,
	Andy Cress <andy.cress@...kontron.com>,
	Mika Lansirine <Mika.Lansirinne@...nesoft.com>,
	Brian De Wolf <bldewolf@...pomona.edu>,
	Jean Michel Audet <Jean-Michel.Audet@...Kontron.com>,
	Jozef Sudelsky <jozef.sudolsky@...iahosting.sk>,
	Matthew Garrett <mjg@...hat.com>,
	Corey Minyard <cminyard@...sta.com>
Subject: [PATCH] ipmi: Fix IPMI errors due to timing problems

From: Doe, YiCheng <yicheng.doe@...com>

This patch fixes an issue in OpenIPMI module where sometimes an ABORT command
is sent after sending an IPMI request to BMC causing the IPMI request to fail.

Signed-off-by: YiCheng Doe <yicheng.doe@...com>
Signed-off-by: Corey Minyard <cminyard@...sta.com>
Acked-by: Tom Mingarelli <thomas.mingarelli@...com>
Tested-by: Andy Cress <andy.cress@...kontron.com>
Tested-by: Mika Lansirine <Mika.Lansirinne@...nesoft.com>
Tested-by: Brian De Wolf <bldewolf@...pomona.edu>
Cc: Jean Michel Audet <Jean-Michel.Audet@...Kontron.com>
Cc: Jozef Sudelsky <jozef.sudolsky@...iahosting.sk>
Cc: Matthew Garrett <mjg@...hat.com>
---
 drivers/char/ipmi/ipmi_si_intf.c |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)

diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c
index 7855f9f..62787e3 100644
--- a/drivers/char/ipmi/ipmi_si_intf.c
+++ b/drivers/char/ipmi/ipmi_si_intf.c
@@ -900,6 +900,14 @@ static void sender(void                *send_info,
 	printk("**Enqueue: %d.%9.9d\n", t.tv_sec, t.tv_usec);
 #endif
 
+	/*
+	 * last_timeout_jiffies is updated here to avoid
+	 * smi_timeout() handler passing very large time_diff
+	 * value to smi_event_handler() that causes
+	 * the send command to abort.
+	 */
+	smi_info->last_timeout_jiffies = jiffies;
+
 	mod_timer(&smi_info->si_timer, jiffies + SI_TIMEOUT_JIFFIES);
 
 	if (smi_info->thread)
-- 
1.7.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/