lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 09 Mar 2011 21:51:26 -0500 From: Steven Rostedt <rostedt@...dmis.org> To: David Sharp <dhsharp@...gle.com> Cc: Darren Hart <dvhart@...ux.intel.com>, linux-kernel@...r.kernel.org, mrubin@...gle.com Subject: Re: [PATCH trace-cmd 3/3] Revert "trace-cmd: Use conditional assignment of CC and AR" On Wed, 2011-03-09 at 18:27 -0800, David Sharp wrote: > On Wed, Mar 9, 2011 at 5:58 PM, Darren Hart <dvhart@...ux.intel.com> wrote: > > dvhart@...bt:templates$ cat Makefile > > ifdef CROSS_COMPILE > > CC = $(CROSS_COMPILE)gcc > > AR = $(CROSS_COMPILE)ar > > endif > > > > all: > > echo "CC: $(CC)" > > > > dvhart@...bt:templates$ make -s > > CC: cc > > > > dvhart@...bt:templates$ CC=gcc-4.5.1 make -s > > CC: gcc-4.5.1 > > > > dvhart@...bt:templates$ CROSS_COMPILE=my-cross- make -s > > CC: my-cross-gcc > > > > > > Seems to meet everyone's needs without changing any tools/scripts/etc that > > have used trace-cmd before or after the CC ?= wreckage. > > It's a little odd that the default CC is "cc" unless you supply > CROSS_COMPILE, then it's "gcc". I'd probably be okay with this, but I > would think it's weird. > > I don't know the answers, but if we take the kernel Makefile as a > template, then setting CC doesn't work. > I really don't care much for this either. But I'm trying to make it work for everyone. Honestly, I think the BUILD_CC version is the cleanest, but I understand that this will add a burden onto Darren to fix his tools to handle it, whereas, I would like to avoid that. I'll play with some other make tricks and see if I can come up with a better solution. -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists