linux-kernel - Re: [PATCH 1/2] hid-ntrig: sysfs nodes for modes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4D79F1DD.10009@seas.upenn.edu>
Date:	Fri, 11 Mar 2011 04:56:45 -0500
From:	Rafi Rubin <rafi@...s.upenn.edu>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>
CC:	jkosina@...e.cz, linux-input@...r.kernel.org,
	linux-kernel@...r.kernel.org, micki@...rig.com,
	rydberg@...omail.se, chatty@...c.fr
Subject: Re: [PATCH 1/2] hid-ntrig: sysfs nodes for modes

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

User desires aren't exactly my specialty.  I just know the ntrig windows control
panel gives the user that control with cute little radio buttons.

Would it be cleaner to expose the control with an ioctrl or some other mechanism?

I do have user space tools for mode and calibration, but that requires unbinding
the device, and just seems sloppier.  But if this really is inappropriate to add
the sysfs nodes, at least there's still some solution.

Since you brought it up, I am thinking of removing some of the other nodes soon.
 I've learned the physical and logical ranges are already exposed both through
the event nodes and debugfs.  Also, I have better filtering that so far seems
not to need as many parameters so I should be able to remove those nodes as well.

Still learning,
Rafi

On 03/11/11 03:18, Dmitry Torokhov wrote:
> On Fri, Mar 11, 2011 at 02:37:51AM -0500, Rafi Rubin wrote:
>> Signed-off-by: Rafi Rubin <rafi@...s.upenn.edu>
>>
>> ---
>>
>> If the code is there, might as well expose a friendly interface to the
>> user.
> 
> The bigger question is should the user care? If we can make the device
> work well without user intervention then we should not really expose
> extra attributes.
> 
> Thanks.
> 
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBAgAGBQJNefHZAAoJEPILXytRLnK2ud4QAJxzSX+tIrkZawpqvJM69mf3
1P4+E8vCXqsX9usaayGQoa/+CLe2so6frQo3B5nH8ExTOs8+a/Zx1Y9JbNxwqDBJ
aMeWBhO9stqdGjg2hllFeJNV/vuvlU7y6oOW6qme/sKHp0zfisco2nJNvG3yHAQl
tD0TVgiCeEIWkN/AAqoUxGSMtv9pOmkcVfShDVktmOH6pqAsacP29UENZBAKuqQ6
jHtJ2hfQV5NBrKjlHPhcvTiBRrls5SZ+RfRq4hy8MWC8Vj5rjjNLCxmgBeI5Ktqf
ZTRNVvvHClgIbuwHx5LdzPBFNjYv35A87vW8zMHb6/qU57KkeXL1VX6RcONTOS+w
6fWX2AYVMxs/6rU6nXfa/DxgRlPZqyVGP1E8VZ+bl09fJ41WR7xpsOIko93KemUq
DC+kxp9nyfH7bZEpWsr3chEQkbj2aT+1Rjc6312Vsio2Gbzgth8t0WWxEIX69Sp+
hZCzrFPFKiUrlWOdKQG1TkJNh6Z9a1HQLYb67ga2/liyJt9rW6uUfylQDJqN9adj
iGE9xVX6D4+da0CW+hl+0U+EhGX+ZSmvI5IgVdBGsxZnFa/ReP5nJKGFcJmkTtPO
WcZe0zqxORua6xPqA9p2cScbcvCXiHLQtjpLxBQMLlMgghKunSVX9Hl/3OrtOHRZ
r36BGVFmHWBvddvosBqK
=vHok
-----END PGP SIGNATURE-----
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/