linux-kernel - Re: [PATCH 3/3] tty: serial: Check UPF_FOURPORT, when CONFIG_SERIAL_8250

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110311135502.1add15c9@lxorguk.ukuu.org.uk>
Date:	Fri, 11 Mar 2011 13:55:02 +0000
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@...esas.com>
Cc:	gregkh@...e.de, linux-kernel@...r.kernel.org, arnd@...db.de
Subject: Re: [PATCH 3/3] tty: serial: Check UPF_FOURPORT, when
 CONFIG_SERIAL_8250_FOURPORT is defined

On Fri, 11 Mar 2011 21:58:12 +0900
Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@...esas.com> wrote:

> When CONFIG_SERIAL_8250_FOURPORT is defined, driver uses UPF_FOURPORT in port.flags.
> Though CONFIG_SERIAL_8250_FOURPORT is not defined, there is a case to check UPF_FOURPORT.
> When CONFIG_SERIAL_8250_FOURPORT is defined only, this checks UPF_FOURPORT.

Again all this can be avoided by defining WARN traps for the unsupported
I/O methods in your architecture.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/