linux-kernel - Re: [RESEND PATCH] staging: tidspbridge: protect dmm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTin_2yo705Ka3KO_09nK3ZUEi_0uYfi6fKQqwBVV@mail.gmail.com>
Date:	Fri, 11 Mar 2011 12:05:23 -0600
From:	"Ramirez Luna, Omar" <omar.ramirez@...com>
To:	Felipe Contreras <felipe.contreras@...il.com>
Cc:	Felipe Contreras <felipe.contreras@...ia.com>,
	linux-main <linux-kernel@...r.kernel.org>,
	linux-omap <linux-omap@...r.kernel.org>,
	Greg KH <greg@...ah.com>, Ohad Ben-Cohen <ohad@...ery.com>,
	Fernando Guzman Lugo <fernando.lugo@...com>,
	Tuomas Kulve <tuomas@...ve.fi>
Subject: Re: [RESEND PATCH] staging: tidspbridge: protect dmm_map properly

Hi Felipe,

On Fri, Mar 11, 2011 at 11:38 AM, Felipe Contreras
<felipe.contreras@...il.com> wrote:
> On Fri, Mar 11, 2011 at 7:30 PM, Felipe Contreras
> <felipe.contreras@...ia.com> wrote:
>> We need to protect not only the dmm_map list, but the individual
>> map_obj's, otherwise, we might be building the scatter-gather list with
>> garbage. So, use the existing proc_lock for that.
>>
>> I observed race conditions which caused kernel panics while running
>> stress tests, also, Tuomas Kulve found it happening quite often in
>> Gumstix Over. This patch fixes those.
>>
>> Cc: Tuomas Kulve <tuomas@...ve.fi>
>> Signed-off-by: Felipe Contreras <felipe.contreras@...ia.com>
>
> Omar, 2.6.38 is imminent, if this patch has any chance of getting in,
> I think you would need to push it soon.

I'll push it to my queue, however I don't think this would be even
considered to make it before the official 2.6.38 which should happen
in the next few days, given that it should climb to staging tree first
and from there to mainline... we could attempt to shot directly to the
mainline kernel, but that would raise a few eyebrows and in the end be
rejected as well because this is a staging driver which is still in
process of cleanup.

OTOH, this patch was there long ago, since December, but I just lost
the track of it at the moment, along with the other proposed
solutions, so I take it as my fault for not picking it up then.

Regards,

Omar
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/