linux-kernel - Re: [PATCH] cciss: Add missing allocation in scsi_cmd_stack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110311194644.GE12760@beardog.cce.hp.com>
Date:	Fri, 11 Mar 2011 13:46:44 -0600
From:	scameron@...rdog.cce.hp.com
To:	Jens Axboe <axboe@...nel.dk>
Cc:	mikem@...rdog.cce.hp.com, akpm@...ux-foundation.org,
	thenzl@...hat.com, linux-kernel@...r.kernel.org,
	smcameron@...oo.com, scameron@...rdog.cce.hp.com
Subject: Re: [PATCH] cciss: Add missing allocation in scsi_cmd_stack_setup and  corresponding deallocation

On Fri, Mar 11, 2011 at 08:09:39PM +0100, Jens Axboe wrote:
> On 2011-03-10 21:22, Stephen M. Cameron wrote:
> > From: Stephen M. Cameron <scameron@...rdog.cce.hp.com>
> > 
> > This bit got lost somewhere along the way.  Without this, panic.
> 
> This doesn't apply cleanly, neither hunk. I hand applied it. Please let
> me know what a patch is against in the future, if it doesn't apply
> "anywhere".

Oh... I see what happened.

That patch was fixing something which was accidentally 
left out of this patch:

http://marc.info/?l=linux-kernel&m=129840572232151&w=2

which I mistakenly thought was present in 2.6.38-rc7,
but it's not present (quite likely because without the
missing bit, it causes a panic), It's sitting in my stack of
patches still.

[scameron@...alhost linux-2.6.38-rc7]$ stg series | grep cciss
+ cciss-hoist-tag-masking-out-of-loop
+ cciss-inform-controller-we-are-using-32-bit-tags
+ cciss-mask-off-error-bits-before-calling-pci-free-consistent
+ cciss-remove-unnecessary-casts
+ cciss-fix-missed-command-status-value-CMD_UNABORTABLE
+ cciss-add-cciss_tape_cmds-module-parameter
+ cciss-fix-missing-initialization-in-scsi-cmd-stack-setup
+ cciss-export-resettable-host-attribute
+ cciss-fix-sense-data-copying-code

What needs to happen is I combine cciss-add-cciss_tape_cmds-module-parameter
and cciss-fix-missing-initialization-in-scsi-cmd-stack-setup into one 
working patch.

Sorry about that.  I need to slow down.  I'm making too many mistakes.

-- steve



> 
> I marked this one as stable backport, too.
> 
> -- 
> Jens Axboe
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/