linux-kernel - Re: [PATCH] Platform: add Samsung Laptop platform driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110311195221.GA14719@kroah.com>
Date:	Fri, 11 Mar 2011 11:52:21 -0800
From:	Greg KH <greg@...ah.com>
To:	Matthew Garrett <mjg59@...f.ucam.org>
Cc:	Randy Dunlap <rdunlap@...otime.net>, linux-kernel@...r.kernel.org,
	platform-driver-x86@...r.kernel.org
Subject: Re: [PATCH] Platform: add Samsung Laptop platform driver

On Fri, Mar 11, 2011 at 07:44:22PM +0000, Matthew Garrett wrote:
> On Fri, Mar 11, 2011 at 11:35:12AM -0800, Greg KH wrote:
> > On Fri, Mar 11, 2011 at 05:43:39PM +0000, Matthew Garrett wrote:
> > > Applied, thanks.
> > 
> > Great, any pointers to where it was applied?  I think I need to send you
> > a few more 'add a new device id' patches and I want to make sure I get
> > the right version to patch against.
> 
> http://git.kernel.org/?p=linux/kernel/git/mjg59/platform-drivers-x86.git;a=shortlog;h=refs/heads/linux-next 

Thanks.

> - ideally we'd just have it id against all Samsung laptops and check for 
> SABI? Or are there machines where that might break?

I thought all samsung laptops had SABI, but as the other samsung laptop
driver shows, that's not true.

I don't know what happens if we try to check for SABI on those machines.
We are just rooting around in the BIOS rom and reading values,
_hopefully_ that wouldn't break any other machines, but I don't really
know.

I wouldn't mind just doing a DMI match on all Samsung laptops, it would
save me having to constantly send patch updates, so I'll let this be
your call :)

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/