linux-kernel - Re: [PATCH 21/22] staging: xgifb: rename XGINew_SetRegANDOR() to xgifb_reg_and

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110311213740.GD2008@bicker>
Date:	Sat, 12 Mar 2011 00:37:40 +0300
From:	Dan Carpenter <error27@...il.com>
To:	Aaro Koskinen <aaro.koskinen@....fi>
Cc:	gregkh@...e.de, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org, arnaud.patard@...-net.org
Subject: Re: [PATCH 21/22] staging: xgifb: rename XGINew_SetRegANDOR() to
 xgifb_reg_and_or()

On Thu, Mar 10, 2011 at 11:02:46PM +0200, Aaro Koskinen wrote:
> Rename XGINew_SetRegANDOR() to xgifb_reg_and_or().
> 
> Signed-off-by: Aaro Koskinen <aaro.koskinen@....fi>
> ---

> -void XGINew_SetRegANDOR(unsigned long Port, unsigned short Index,
> -		unsigned short DataAND, unsigned short DataOR)
> +void xgifb_reg_and_or(unsigned long port, u8 index, unsigned data_and,
                                             ^^^^^^^^  ^^^^^^^^^^^^^^^^^
> +		      unsigned data_or)
                      ^^^^^^^^^^^^^^^^
I wish the change log had mentioned some of these data type changes.  It
doesn't cause a bug, but it still should have been mentioned.

>  {
> -	unsigned short temp;
> +	u8 temp;

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/