lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20110312091437.GI9347@angua.secretlab.ca>
Date:	Sat, 12 Mar 2011 02:14:37 -0700
From:	Grant Likely <grant.likely@...retlab.ca>
To:	Axel Lin <axel.lin@...il.com>
Cc:	linux-kernel@...r.kernel.org, Miguel Gaio <miguel.gaio@...xo.com>,
	Mocean Laboratories <info@...ean-labs.com>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] gpio: Use  __devexit at necessary places

On Thu, Mar 10, 2011 at 05:10:45PM +0800, Axel Lin wrote:
> The function gen_74x164_remove and mc33880_remove are used only wrapped
> by __devexit_p so define it using __devexit.
> 
> Signed-off-by: Axel Lin <axel.lin@...il.com>
> Cc: Miguel Gaio <miguel.gaio@...xo.com>
> Cc: Mocean Laboratories <info@...ean-labs.com>

Applied, thanks.

g.

> ---
>  drivers/gpio/74x164.c  |    2 +-
>  drivers/gpio/mc33880.c |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpio/74x164.c b/drivers/gpio/74x164.c
> index d91ff4c..84e0702 100644
> --- a/drivers/gpio/74x164.c
> +++ b/drivers/gpio/74x164.c
> @@ -133,7 +133,7 @@ exit_destroy:
>  	return ret;
>  }
>  
> -static int gen_74x164_remove(struct spi_device *spi)
> +static int __devexit gen_74x164_remove(struct spi_device *spi)
>  {
>  	struct gen_74x164_chip *chip;
>  	int ret;
> diff --git a/drivers/gpio/mc33880.c b/drivers/gpio/mc33880.c
> index 935479d..00f6d24 100644
> --- a/drivers/gpio/mc33880.c
> +++ b/drivers/gpio/mc33880.c
> @@ -146,7 +146,7 @@ exit_destroy:
>  	return ret;
>  }
>  
> -static int mc33880_remove(struct spi_device *spi)
> +static int __devexit mc33880_remove(struct spi_device *spi)
>  {
>  	struct mc33880 *mc;
>  	int ret;
> -- 
> 1.7.2
> 
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ