| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Sat, 12 Mar 2011 14:27:35 +0100 From: roel <roel.kluin@...il.com> To: "J. Bruce Fields" <bfields@...ldses.org>, Neil Brown <neilb@...e.de>, linux-nfs@...r.kernel.org, Andrew Morton <akpm@...ux-foundation.org>, LKML <linux-kernel@...r.kernel.org> Subject: [PATCH] SUNRPC: svc_register error overwritten in next iteration The break is in the inner loop, the svc_register() error is overwritten in the next iteration. Only the error in the last iteration is returned. Signed-off-by: Roel Kluin <roel.kluin@...il.com> --- net/sunrpc/svc.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) Is this needed? diff --git a/net/sunrpc/svc.c b/net/sunrpc/svc.c index 08e05a8..5fd08c0 100644 --- a/net/sunrpc/svc.c +++ b/net/sunrpc/svc.c @@ -889,6 +889,8 @@ int svc_register(const struct svc_serv *serv, const int family, if (error < 0) break; } + if (error < 0) + break; } return error; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists