linux-kernel - Re: [RFC PATCH 1/4] PLATFORM: introduce structure to bind async platform data to a dev path name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110313161435.GA10718@kroah.com>
Date:	Sun, 13 Mar 2011 09:14:35 -0700
From:	Greg KH <greg@...ah.com>
To:	andy.green@...aro.org
Cc:	"Rafael J. Wysocki" <rjw@...k.pl>, linux-kernel@...r.kernel.org,
	linux-usb@...r.kernel.org, patches@...aro.org
Subject: Re: [RFC PATCH 1/4] PLATFORM: introduce structure to bind async
 platform data to a dev path name

On Sun, Mar 13, 2011 at 11:22:40AM +0000, Andy Green wrote:
> On 03/13/2011 01:03 AM, Somebody in the thread at some point said:
> 
> >>>Using device paths for this purpose seems to be very fragile to me.  Isn't
> >>>there any better solution?
> >>
> >>Given that this targets board definition files which commonly do the
> >>platform_add_device for the USB bus controller synchronously, and
> >>the bus-connected devices it is aimed at are soldered on to the
> >>board connected to specific bus controllers, the bus paths are
> >>completely deterministic.
> >
> >No they are not.
> >
> >The physical layout is deterministic, but the bus number, and device
> >number, is not.  You are using the bus number here in this path, so that
> >is not going to work, sorry.
> 
> Okay.  This is not a PC we are talking about.

I know that, and again, it doesn't matter.

You CAN NOT GUARANTEE the USB device ordering of bus numbers or device
numbers.  It's that simple.

> If the platform / board definition file is registering the USB hosts
> synchronously at boot time, the driver is composed into the
> monolithic kernel, there are no PCI busses or whatever on the SoC,
> the bus indexing is totally deterministic.

Not true, it could change for a number of reasons, not the least being
your kernel version changed.

So again NEVER rely on this, bad things could happen in the field when
you least expect it.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/