linux-kernel - Re: [PATCH 2/2] hid-ntrig: init settle and mode check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1103141310380.19969@pobox.suse.cz>
Date:	Mon, 14 Mar 2011 13:10:49 +0100 (CET)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Peter Hutterer <peter.hutterer@...-t.net>
Cc:	Rafi Rubin <rafi@...s.upenn.edu>, linux-input@...r.kernel.org,
	linux-kernel@...r.kernel.org, micki@...rig.com,
	rydberg@...omail.se, chatty@...c.fr
Subject: Re: [PATCH 2/2] hid-ntrig: init settle and mode check

On Fri, 11 Mar 2011, Peter Hutterer wrote:

> > Adding a wait before the wakeup signal.
> > 
> > As a precautionary measure sanity check the current sensor mode.  If
> > needed reset it to "dual".
> > 
> > Signed-off-by: Rafi Rubin <rafi@...s.upenn.edu>
> > 
> > When the device is responding poorly and needs the wakeup call, it was
> > missing it.  Giving it a chance to settle first improves the chances
> > that signal gets through.
> > 
> > I was also seeing the device come up in strange modes where it did not
> > respond to physical stimulus.  Hopefully the quirk will fix that, but
> > even so it seems like a good idea to check.  It also makes me curious
> > what the "off" code is.
> > ---
> >  drivers/hid/hid-ntrig.c |   45 +++++++++++++++++++++++++++++++++++++++++++--
> >  1 files changed, 43 insertions(+), 2 deletions(-)
> 
> no negative effects
> 
> Tested-by: Peter Hutterer <peter.hutterer@...-t.net>

Applied, thanks.

-- 
Jiri Kosina
SUSE Labs, Novell Inc.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/