linux-kernel - Re: [PATCH] x86, tlb: small cleanup for native_flush_tlb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 14 Mar 2011 13:33:55 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Xiao Guangrong <xiaoguangrong@...fujitsu.com>
Cc:	hpa@...or.com, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86, tlb: small cleanup for native_flush_tlb_others


* Xiao Guangrong <xiaoguangrong@...fujitsu.com> wrote:

> Use smp_processor_id instead of get_cpu and put_cpu since
> the caller has already disabled preemption
> 
> Signed-off-by: Xiao Guangrong <xiaoguangrong@...fujitsu.com>
> ---
>  arch/x86/mm/tlb.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/x86/mm/tlb.c b/arch/x86/mm/tlb.c
> index 6acc724..92849d0 100644
> --- a/arch/x86/mm/tlb.c
> +++ b/arch/x86/mm/tlb.c
> @@ -211,11 +211,10 @@ void native_flush_tlb_others(const struct cpumask *cpumask,
>  	if (is_uv_system()) {
>  		unsigned int cpu;
>  
> -		cpu = get_cpu();
> +		cpu = smp_processor_id();
>  		cpumask = uv_flush_tlb_others(cpumask, mm, va, cpu);
>  		if (cpumask)
>  			flush_tlb_others_ipi(cpumask, mm, va);
> -		put_cpu();
>  		return;

There's multiple callers. Could you please update the changelog with the list of 
callers and a statement that all of them disable preemption already?

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/