linux-kernel - Re: [PATCH 1/3]trace-cmd: remove dead code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1300109298.9910.66.camel@gandalf.stny.rr.com>
Date:	Mon, 14 Mar 2011 09:28:18 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Lai Jiangshan <laijs@...fujitsu.com>
Cc:	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/3]trace-cmd: remove dead code

On Mon, 2011-03-14 at 10:30 +0800, Lai Jiangshan wrote:
> On 03/10/2011 10:53 PM, Steven Rostedt wrote:
> > On Thu, 2011-03-10 at 17:57 +0800, Lai Jiangshan wrote:
> >> filter_cpu related code is totally dead.
> > 
> > I'll rephrase this, as it is not dead. "dead" code is code that can not
> > be reached. This code most certainly can be reached. You may think it is
> > silly code, which it may be. The reason for the separation of one CPU
> > and multiple CPUs, is I do one CPU more often than I filter multiple,
> > and I wanted the 1 cpu to still be efficient.
> > 
> 
> I'm confused, filter_cpu is always -1, how the code can be reached?

Ah, you're right. Because of a bug:

-	if (filter_cpu)
+	if (filter_cpu >= 0)
		add_cpu(optarg);
	else
		filter_cpu = atoi(optarg);

Was what it was suppose to be.

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/