linux-kernel - Re: [PATCH R4 4/7] xen/balloon: Protect against CPU exhaust by event/x process

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1300115089.17339.2183.camel@zakaz.uk.xensource.com>
Date:	Mon, 14 Mar 2011 15:04:49 +0000
From:	Ian Campbell <Ian.Campbell@...citrix.com>
To:	Daniel Kiper <dkiper@...-space.pl>
CC:	"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
	"andi.kleen@...el.com" <andi.kleen@...el.com>,
	"haicheng.li@...ux.intel.com" <haicheng.li@...ux.intel.com>,
	"fengguang.wu@...el.com" <fengguang.wu@...el.com>,
	"jeremy@...p.org" <jeremy@...p.org>,
	"konrad.wilk@...cle.com" <konrad.wilk@...cle.com>,
	"Dan Magenheimer" <dan.magenheimer@...cle.com>,
	"v.tolstov@...fip.ru" <v.tolstov@...fip.ru>,
	"pasik@....fi" <pasik@....fi>,
	"dave@...ux.vnet.ibm.com" <dave@...ux.vnet.ibm.com>,
	"wdauchy@...il.com" <wdauchy@...il.com>,
	"rientjes@...gle.com" <rientjes@...gle.com>,
	"xen-devel@...ts.xensource.com" <xen-devel@...ts.xensource.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-mm@...ck.org" <linux-mm@...ck.org>
Subject: Re: [PATCH R4 4/7] xen/balloon: Protect against CPU exhaust by
 event/x process

On Tue, 2011-03-08 at 21:48 +0000, Daniel Kiper wrote:
> Protect against CPU exhaust by event/x process during
> errors by adding some delays in scheduling next event
> and retry count limit.

The addition of a default retry count limit reverses the change made in
bc2c0303226ec716854d3c208c7f84fe7aa35cd7. That change was made to allow
system wide ballooning daemons to work as expected and I don't think a
strong argument has been made for undoing it here.

I think the exponential back-off element of this patch is probably all
that is needed to avoid using too much CPU.

We are talking about polling at most once a second (backing off pretty
quickly to once every 32s with this patch) -- is that really enough to
"exhaust" the CPU running event/x?

Also this patch seems to make the driver quite chatty:

> +	pr_info("xen_balloon: Retry count: %lu/%lu\n", balloon_stats.retry_count,
> +			balloon_stats.max_retry_count);

Not needed. The balloon driver is a best effort background thing, it
doesn't need to be spamming the system logs each time something doesn't
go quite right first time, it should just continue on silently in the
background. It should only be logging if something goes catastrophically
wrong (in which case pr_info isn't really sufficient).

> +	if (rc <= 0) {
> +		pr_info("xen_balloon: %s: Cannot allocate memory\n", __func__);

Likewise.

> +			pr_info("xen_balloon: %s: Cannot allocate memory\n", __func__);

And again.

Ian.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/