linux-kernel - Re: [PATCH v2 12/12] driver: Google Memory Console

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110314154756.GG31340@kroah.com>
Date:	Mon, 14 Mar 2011 08:47:56 -0700
From:	Greg KH <greg@...ah.com>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Tim Hockin <thockin@...gle.com>, "H. Peter Anvin" <hpa@...nel.org>,
	Mike Waychison <mikew@...gle.com>,
	Matt Domsch <Matt_Domsch@...l.com>,
	Alan Cox <alan@...rguk.ukuu.org.uk>,
	Duncan Laurie <dlaurie@...gle.com>,
	Aaron Durbin <adurbin@...gle.com>, x86@...nel.org,
	linux-kernel@...r.kernel.org, San Mehat <san@...gle.com>
Subject: Re: [PATCH v2 12/12] driver: Google Memory Console

On Mon, Mar 14, 2011 at 03:23:15PM +0100, Ingo Molnar wrote:
> 
> * Tim Hockin <thockin@...gle.com> wrote:
> 
> > This same BIOS logic is used across a number of Platforms.  We could
> > use something like the vendor strings to trigger this code off, [...]
> 
> Correct.
> 
> > [...] I suppose, but ick.  It's already in a google/ subdir and wrapped with 
> > CONFIG_GOOGLE_MEMCONSOLE.
> 
> That's not the point though - in this day and age we simply do not add non-generic 
> hacks like that - we've come a long way since the ISA days. The point is to make it 
> safe enough to limit its effects not just to CONFIG_GOOGLE_MEMCONSOLE but also to 
> affected hardware only.

I strongly agree, we can't take this as-is without this type of code
added to the driver, sorry.

Thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/