[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20110314154510.GE31340@kroah.com>
Date: Mon, 14 Mar 2011 08:45:10 -0700
From: Greg KH <greg@...ah.com>
To: Mike Waychison <mikew@...gle.com>
Cc: Matt Domsch <Matt_Domsch@...l.com>,
Alan Cox <alan@...rguk.ukuu.org.uk>,
Duncan Laurie <dlaurie@...gle.com>,
Aaron Durbin <adurbin@...gle.com>, x86@...nel.org,
linux-kernel@...r.kernel.org, Tim Hockin <thockin@...gle.com>,
San Mehat <san@...gle.com>
Subject: Re: [PATCH v2 10/12] Introduce CONFIG_GOOGLE_FIRMWARE
On Fri, Mar 11, 2011 at 05:43:47PM -0800, Mike Waychison wrote:
> In order to keep Google's firmware drivers organized amongst themselves,
> create a new directory for them to live in. As well, all Google
> firmware drivers are gated on CONFIG_GOOGLE_FIRMWARE=y, which defaults
> to 'n' in the kernel build.
Everything defaults to 'n' in the kernel build system, so this really
isn't a big deal :)
>
> Signed-off-by: Mike Waychison <mikew@...gle.com>
> ---
> drivers/firmware/Kconfig | 2 ++
> drivers/firmware/Makefile | 2 ++
> drivers/firmware/google/Kconfig | 14 ++++++++++++++
> drivers/firmware/google/Makefile | 1 +
> 4 files changed, 19 insertions(+), 0 deletions(-)
> create mode 100644 drivers/firmware/google/Kconfig
> create mode 100644 drivers/firmware/google/Makefile
>
> diff --git a/drivers/firmware/Kconfig b/drivers/firmware/Kconfig
> index e710424..d848b26 100644
> --- a/drivers/firmware/Kconfig
> +++ b/drivers/firmware/Kconfig
> @@ -134,4 +134,6 @@ config ISCSI_IBFT
> detect iSCSI boot parameters dynamically during system boot, say Y.
> Otherwise, say N.
>
> +source "drivers/firmware/google/Kconfig"
> +
> endmenu
> diff --git a/drivers/firmware/Makefile b/drivers/firmware/Makefile
> index 1c3c173..6f68007 100644
> --- a/drivers/firmware/Makefile
> +++ b/drivers/firmware/Makefile
> @@ -11,3 +11,5 @@ obj-$(CONFIG_DMIID) += dmi-id.o
> obj-$(CONFIG_ISCSI_IBFT_FIND) += iscsi_ibft_find.o
> obj-$(CONFIG_ISCSI_IBFT) += iscsi_ibft.o
> obj-$(CONFIG_FIRMWARE_MEMMAP) += memmap.o
> +
> +obj-$(CONFIG_GOOGLE_FIRMWARE) += google/
> diff --git a/drivers/firmware/google/Kconfig b/drivers/firmware/google/Kconfig
> new file mode 100644
> index 0000000..7834729
> --- /dev/null
> +++ b/drivers/firmware/google/Kconfig
> @@ -0,0 +1,14 @@
> +config GOOGLE_FIRMWARE
> + bool "Google Firmware Drivers"
> + depends on X86
> + default n
> + help
> + These firmware drivers are used by Google's servers. They are
> + only useful if you are working directly on one of their
> + proprietary servers or implementing similar firmware
> + interfaces. If in doubt, say "N".
How about dropping the "or implementing..." part of this sentance, as
that leaves a lot open for some people to justify enabling this option
for their machines, when it really isn't true at all at this point in
time.
thanks,
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists